Re: Our naming of wait events is a disaster.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Isaac Morland <isaac(dot)morland(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Our naming of wait events is a disaster.
Date: 2020-05-14 20:03:37
Message-ID: CA+TgmoaKfN+5+Mbmhi+9GiZw8-zkrNMb3FFXB3B=ZY6KdopP5w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 14, 2020 at 3:58 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I submit that at least part of the problem is precisely one of crappy
> naming. I didn't know what OldSerXidLock did either, until yesterday
> when I dug into the code to find out. If it's named something like
> "SerialSLRULock", then at least somebody who has heard of SLRUs will
> have an idea of what is indicated. And we are exposing the notion
> of SLRUs pretty prominently in the monitoring docs as of v13, so that's
> not an unreasonable presumption.

To the extent that exposing some of this information causes us to
think more carefully about the naming, I think that's all to the good.
I don't expect such measures to solve all of our problems in this
area, but the idea that we can choose names with no consideration to
whether anybody can understand what they mean is wrong even when the
audience is only developers.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2020-05-14 20:20:54 Re: Parallel copy
Previous Message Peter Eisentraut 2020-05-14 20:02:49 Re: new heapcheck contrib module