| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com> |
| Cc: | Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: basebackup.c's sendFile() ignores read errors |
| Date: | 2019-09-05 18:10:37 |
| Message-ID: | CA+TgmoaESYdgPE1THF1JiSiep5UM6hF_EXbJCb+qxD=oS8Xc=g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Aug 30, 2019 at 7:05 AM Jeevan Ladhe
<jeevan(dot)ladhe(at)enterprisedb(dot)com> wrote:
>> Fixed both comments in the attached patch.
>
> Thanks, the patch looks good to me.
Here's a version of the patch with a further change to the wording of
the comment. I hope this is clearer.
I think this needs to be back-patched all the way back to 9.4, and it
doesn't seem to apply cleanly before v11. Any chance you could
prepare a version for the older branches?
Thanks,
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| fread-error-check-v3.patch | application/octet-stream | 2.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-09-05 18:22:54 | Re: [PATCH] Connection time for \conninfo |
| Previous Message | Paul A Jungwirth | 2019-09-05 17:45:55 | Re: range_agg |