| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Tatsuo Ishii <ishii(at)postgresql(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Patch: add conversion from pg_wchar to multibyte |
| Date: | 2012-07-06 00:43:24 |
| Message-ID: | CA+TgmoaDtJbhMgNKB8rLGP147g0DVYyEJw6ajpCsAsW3TR14bQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 5, 2012 at 7:11 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Sun, Jul 1, 2012 at 5:11 AM, Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
>>> [ new patch ]
>
>> With the improved comments in pg_wchar.h, it seemed clear what needed
>> to be done here, so I fixed up the MULE conversion and committed this.
>> I'd appreciate it if someone would check my work, but I think it's
>> right.
>
> Hm, several of these routines seem to neglect to advance the "from"
> pointer?
Err... yeah. That's not a bug I introduced, but I should have caught
it... and it does make me wonder how well this code was tested.
Does the attached look like an appropriate fix?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| wchar-advance-from.patch | application/octet-stream | 720 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2012-07-06 00:46:35 | Re: Patch: add conversion from pg_wchar to multibyte |
| Previous Message | Bruce Momjian | 2012-07-06 00:13:44 | Re: obsolete copyright notice |