Re: CATUPDATE confusion?

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Adam Brightwell <adam(dot)brightwell(at)crunchydatasolutions(dot)com>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: CATUPDATE confusion?
Date: 2015-03-10 12:52:54
Message-ID: CA+TgmoaCea0wKzT0W4z7onHTVzogemP5Za+6wwWKsC4WJoin5A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Mar 7, 2015 at 6:40 PM, Adam Brightwell
<adam(dot)brightwell(at)crunchydatasolutions(dot)com> wrote:
>> pg_shadow, pg_user and pg_group were added when role support was added,
>> specifically for backwards compatibility. I don't believe there was
>> ever discussion about keeping them because filtering pg_roles based on
>> rolcanlogin was too onerous. That said, we already decided recently
>> that we wanted to keep them updated to match the actual attributes
>> available (note that the replication role attribute modified those
>> views) and I think that makes sense on the removal side as well as the
>> new-attribute side.
>>
>> I continue to feel that we really should officially deprecate those
>> views as I don't think they're actually all that useful any more and
>> maintaining them ends up bringing up all these questions, discussion,
>> and ends up being largely busy-work if no one really uses them.
>
> Deprecation would certainly seem like an appropriate path for 'usecatupd'
> (and the mentioned views). Though, is there a 'formal' deprecation
> policy/process that the community follows? I certainly understand and
> support giving client/dependent tools the time and opportunity to update
> accordingly. Therefore, I think having them read from 'rolsuper' for the
> time being would be ok, provided that they are actually removed at the next
> possible opportunity. Otherwise, I'd probably lean towards just removing
> them now and getting it over with.

Unless some popular tool like pgAdmin is using these views, I'd say we
should just nuke them outright. If it breaks somebody's installation,
then they can always recreate the view on their particular system.
That seems like an adequate workaround to me.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2015-03-10 12:55:12 Re: [REVIEW] Re: Compression of full-page-writes
Previous Message David Rowley 2015-03-10 12:32:24 Re: Performance improvement for joins where outer side is unique