Re: flags argument for dsm_create

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: flags argument for dsm_create
Date: 2015-03-19 17:08:40
Message-ID: CA+TgmoaBpo+x8FNjcqVUaNvY8A_1YApn6B3tUuB6xTssecd-1A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Mar 19, 2015 at 12:21 PM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> * Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
>> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> > I'm slightly confused. Does that mean "just change it" or does that
>> > mean "add dsm_create_extended instead"?
>>
>> FWIW, I vote for "just change it". We change C-level APIs all the time,
>> and this function has surely not got either the longevity nor the wide
>> usage that might argue for keeping its API sancrosanct.
>
> Agreed.

OK, committed that way after, uh, actually testing it and fixing the bugs.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2015-03-19 17:17:12 Re: Collation-aware comparisons in GIN opclasses
Previous Message Alvaro Herrera 2015-03-19 17:08:06 Re: GSoC 2015: Extra Jsonb functionality