Re: pgsql: Fix parallel-safety markings for contrib/dblink.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Fix parallel-safety markings for contrib/dblink.
Date: 2016-06-18 04:53:04
Message-ID: CA+TgmoaAgURV2Ck3T5W-ffuHc1+tk1G=h_DHsqWhbDXhqu77Ww@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Fri, Jun 17, 2016 at 11:08 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Fix parallel-safety markings for contrib/dblink.
>
> As shown by buildfarm reports, dblink_build_sql_insert and
> dblink_build_sql_update are *not* parallel safe, because they
> may attempt to access temporary tables of the local session.
>
> Although dblink_build_sql_delete doesn't actually touch the
> contents of the referenced table, it seems consistent and prudent
> to mark it PARALLEL RESTRICTED too.

Ugh, thanks. I thought that's how they WERE marked, but evidently my
eyes were crossing by this point.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2016-06-18 04:57:44 Re: pgsql: Try again to fix the way the scanjoin_target is used with partia
Previous Message Tom Lane 2016-06-18 04:36:12 Re: pgsql: Try again to fix the way the scanjoin_target is used with partia