Re: Eagerly scan all-visible pages to amortize aggressive vacuum

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Melanie Plageman <melanieplageman(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Robert Treat <rob(at)xzilla(dot)net>, Marcos Pegoraro <marcos(at)f10(dot)com(dot)br>, Alena Rybakina <a(dot)rybakina(at)postgrespro(dot)ru>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Geoghegan <pg(at)bowt(dot)ie>
Subject: Re: Eagerly scan all-visible pages to amortize aggressive vacuum
Date: 2025-02-04 17:17:35
Message-ID: CA+TgmoaA4_GdWbYWdFdUkAMcWBXQnctzBEpQDa8EvSEpOLUFGQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Feb 3, 2025 at 9:09 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> > + <varlistentry id="guc-vacuum-max-eager-freeze-failure-rate" xreflabel="vacuum_max_eager_freeze_failure_rate">
> > + <term><varname>vacuum_max_eager_freeze_failure_rate</varname> (<type>floating point</type>)
> > + <indexterm>
> > + <primary><varname>vacuum_max_eager_freeze_failure_rate</varname> configuration parameter</primary>
> > + </indexterm>
> > + </term>
> > + <listitem>
> > + <para>
> > + Specifies the maximum fraction of pages that
> > + <command>VACUUM</command> may scan and <emphasis>fail</emphasis> to set
> > + all-frozen in the visibility map before disabling eager scanning. A
> > + value of <literal>0</literal> disables eager scanning altogether. The
> > + default is <literal>0.03</literal> (3%).
> > + </para>
>
> Fraction of what?

"pages", according to the text.

I'm not really sure what you think is wrong with this. There may be an
even better way to explain this but this doesn't seem bad to me.

--
Robert Haas
EDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2025-02-04 17:23:59 Re: Orphaned users in PG16 and above can only be managed by Superusers
Previous Message Matthias van de Meent 2025-02-04 17:15:08 Re: RFC: Packing the buffer lookup table