| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Nikolay Shaplov <dhyan(at)nataraj(dot)su> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH][PROPOSAL] Add enum releation option type |
| Date: | 2018-11-01 14:58:04 |
| Message-ID: | CA+Tgmoa9axjx4WkiFp+70E5rSsAwHE377O73jMZXCw1MRj3gNg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 7, 2018 at 10:23 AM Nikolay Shaplov <dhyan(at)nataraj(dot)su> wrote:
> > I see you lost the Oxford comma:
> >
> > -DETAIL: Valid values are "on", "off", and "auto".
> > +DETAIL: Valid values are "auto", "on" and "off".
> >
> > Please put these back.
> Actually that's me who have lost it. The code with oxford comma would be a
> bit more complicated. We should put such coma when we have 3+ items and do not
> put it when we have 2.
>
> Does it worth it?
In my opinion, it is worth it.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2018-11-01 15:01:22 | Re: PG vs macOS Mojave |
| Previous Message | Tom Lane | 2018-11-01 14:53:03 | Re: PG vs macOS Mojave |