Re: in-catalog Extension Scripts and Control parameters (templates?)

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Stephen Frost <sfrost(at)snowman(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: in-catalog Extension Scripts and Control parameters (templates?)
Date: 2013-03-28 11:38:55
Message-ID: CA+Tgmoa75M2qoD5mMr+QOPWNdChad7MN_JOg48+Mi8fZnZz=Jw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 27, 2013 at 10:32 AM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
>> Surely creating an extension template must be a superuser-only
>> operation, in which case this is an issue because Mallory could also
>> have just blown up the world directly if he's already a superuser
>> anyway.
>
> Yeah .. (except "this is NOT an issue")
>
>> If the current patch isn't enforcing that, it's 100% broken.
>
> Even if it's not enforcing that, it's not 100% broken, it only contains
> one more bug we need to fix.

Sure. I didn't mean that such a mistake would make the patch
unsalvageable, only that it would be disastrous from a security point
of view. But as you say, pretty easy to fix.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Farina 2013-03-28 12:35:57 Re: Default connection parameters for postgres_fdw and dblink
Previous Message Robert Haas 2013-03-28 11:36:26 Re: [COMMITTERS] pgsql: Allow external recovery_config_directory