From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Changing WAL Header to reduce contention during ReserveXLogInsertLocation() |
Date: | 2018-03-24 12:19:20 |
Message-ID: | CA+Tgmoa5Jhu8JmYc2KpTdx9OTALkzAX-zHsfSkD6yEHt9AEGBw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Mar 24, 2018 at 8:11 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> On 24 March 2018 at 11:58, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Sat, Mar 24, 2018 at 7:42 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>>> I suggest we focus on the engineering. I've not discussed this patch
>>> with Pavan offline.
>>
>> Well then proposing to commit moments after it's been posted is
>> ridiculous. That's exactly the opposite of "focusing on the
>> engineering".
>>
>> This is a patch about which multiple people have expressed concerns.
>> You're trying to jam a heavily redesigned version in at the last
>> minute without adequate review. Please don't do that.
>
> All presumption on your part. Don't tell me what I think and then diss
> me for that.
It is of course true that I can't know your internal mental state with
certainty, but I don't think it is presumptuous to suppose that a
person who says they're going to commit a patch that hasn't been
reviewed intends to commit a patch that hasn't been reviewed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2018-03-24 12:27:36 | Re: [HACKERS] MERGE SQL Statement for PG11 |
Previous Message | Robert Haas | 2018-03-24 12:16:55 | Re: [HACKERS] MERGE SQL Statement for PG11 |