Re: MERGE SQL statement for PG12

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>
Cc: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Jaime Casanova <jaime(dot)casanova(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: MERGE SQL statement for PG12
Date: 2019-01-10 21:15:34
Message-ID: CA+Tgmoa38C6ULAwmp3K7+pER8PxSsyLpePgBHRQr408-Gyt8Yw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jan 3, 2019 at 2:11 AM Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com> wrote:
> On Tue, Nov 27, 2018 at 4:48 PM Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com> wrote:
>> In the meanwhile, I am posting a rebased version.
>
> Another rebase on the current master.

I feel like there has been some other thread where this was discussed,
but I can't find it right now. I think that the "query construction"
logic in transformMergeStmt is fundamentally the wrong way to do this.
I think several others have said the same. And I don't think this
should be considered for commit until that is rewritten.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2019-01-10 21:23:34 Re: [HACKERS] pgbench - allow to store select results into variables
Previous Message Fabien COELHO 2019-01-10 21:01:12 Re: [HACKERS] pgbench - allow to store select results into variables