Re: Tab completion for CREATE SEQUENCE

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Brendan Jurd <direvus(at)gmail(dot)com>, Vik Fearing <vik(at)2ndquadrant(dot)fr>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Tab completion for CREATE SEQUENCE
Date: 2015-08-04 16:30:08
Message-ID: CA+Tgmoa2bpSOOMd_tUAUaM+C-ogQek-567mc272OVdJ+rN4wQw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Aug 3, 2015 at 2:17 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Tue, Jul 7, 2015 at 9:14 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
>> On 2015-06-19 06:41:19 +0000, Brendan Jurd wrote:
>>> I'm marking this "Waiting on Author". Once the problems have been
>>> corrected, it should be ready for a committer.
>>
>> Vik, are you going to update the patch?
>
> Seeing no activity on this thread and as it would be a waste not to do
> it, I completed the patch as attached. The following things are done:
> - Fixed code indentation
> - Removal of "RESTART", "SET SCHEMA", "OWNER TO", and "RENAME TO" in
> CREATE SEQUENCE
> - Added "START WITH".
> - Added TEMP/TEMPORARY in the set of keywords tracked.
> I am switching at the same time this patch as "Ready for committer".

You didn't remove RESTART, so I did that. And this needed some more
parentheses to make my compiler happy.

Committed with those changes.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2015-08-04 17:13:43 Re: patch: prevent user from setting wal_buffers over 2GB bytes
Previous Message Robert Haas 2015-08-04 16:11:02 Re: Reduce ProcArrayLock contention