| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Rafia Sabih <rafia(dot)sabih(at)enterprisedb(dot)com>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Parallel bitmap heap scan |
| Date: | 2017-02-07 22:14:19 |
| Message-ID: | CA+Tgmoa01pFSnGJqQ_C0WAh4RWOHgJ1MsDb1HijMHiFz6qRA8g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Feb 7, 2017 at 4:45 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2017-02-07 16:36:55 -0500, Robert Haas wrote:
>> On Tue, Feb 7, 2017 at 4:15 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
>> > FWIW, I think it'd have been better to not add the new callbacks as
>> > parameters to *_create(), but rather have them be "templatized" like the
>> > rest of simplehash. That'd require that callback to check the context,
>> > to know whether it should use shared memory or not, but that seems fine
>> > to me. Right now this pushes the head of simplehash above a
>> > cacheline...
>>
>> Something like the attached?
>
> Yes.
>
>> +#ifndef SH_USE_NONDEFAULT_ALLOCATOR
>> +
>
> That should probably be documented in the file header.
Right. OK, did that and a few other cleanups, and committed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jonathan S. Katz | 2017-02-07 22:37:32 | Re: Press Release Draft - 2016-02-09 Cumulative Update |
| Previous Message | Andres Freund | 2017-02-07 21:45:18 | Re: Parallel bitmap heap scan |