| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amul Sul <sulamul(at)gmail(dot)com> |
| Cc: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: small pg_combinebackup improvements |
| Date: | 2024-11-04 15:26:41 |
| Message-ID: | CA+Tgmoa-wcC=AjD1FKcyVq004TKydcr5DcNB4vS0uc-tSC2EBg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Nov 3, 2024 at 11:40 PM Amul Sul <sulamul(at)gmail(dot)com> wrote:
> +1 for the back-patching.
>
> For 0002, I think we could report the error a bit earlier — the better
> place might be in the else part of the following IF-block, IMO:
>
> /*
> * If s->header_length == 0, then this is a full file; otherwise, it's
> * an incremental file.
> */
> if (s->header_length == 0)
We could, but I have some follow-up patches adding some new
functionality which I plan to post soon, and for those patches, it
turns out to be more convenient to have the error check where I put
it. So I'm sticking with that placement.
Committed and back-patched both to v17; thanks to both of you for the review.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2024-11-04 15:53:32 | Re: pgsql: Implement pg_wal_replay_wait() stored procedure |
| Previous Message | vignesh C | 2024-11-04 15:16:25 | Re: Pgoutput not capturing the generated columns |