Re: [PATCH][Documination] Add optional USING keyword before opclass name in INSERT statemet

On Thu, May 26, 2016 at 3:28 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Nikolay Shaplov <n(dot)shaplov(at)postgrespro(dot)ru> writes:
>> Actually I did not expected any discussion for this case. Documentations
>> missed an optional keyword, documentation should be fixed.
>
> 99% of the time, you'd be right. But this is an unusual case, for the
> reasons I mentioned before.

I tend to agree with Nikolay. I can't see much upside in making this
change. At best, nothing will break. At worst, something will break.
But how do we actually come out ahead? The only thing you've offered
is that it might make it easier to make the relevant documentation
pages 100% clear, but I feel like a man of your elocution can probably
surmount that impediment. I guess we might save a few parser states,
too.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company