Re: PageIsAllVisible()'s trustworthiness in Hot Standby

On Wed, Dec 12, 2012 at 12:31 PM, Pavan Deolasee
<pavan(dot)deolasee(at)gmail(dot)com> wrote:
> On Wed, Dec 12, 2012 at 1:35 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Tue, Dec 4, 2012 at 12:10 PM, Pavan Deolasee
>> <pavan(dot)deolasee(at)gmail(dot)com> wrote:
>>> Hmm. Yeah, I do not have guts to prove that either. I'll probably write up a
>>> comment for your consideration to explain why we don't trust PD_ALL_VISIBLE
>>> in Hot standby for seq scans, but still trust VM for index-only scans.
>>
>> Sure.
>>
>
> Here is a small patch that adds comments to heap scan code explaining
> why we don't trust the all-visible flag in the page, still continue to
> support index-only scans on hot standby.

Committed, with a few modifications to the last part.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company