Re: DROP and ddl_command_end.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: DROP and ddl_command_end.
Date: 2020-03-12 13:06:15
Message-ID: CA+TgmoZyswync4yoi9bF4FshVHqn7UsdhJaXGLUkEujOH9tNsQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Mar 9, 2020 at 11:54 PM Kyotaro Horiguchi
<horikyota(dot)ntt(at)gmail(dot)com> wrote:
> Yes, right and I know. I intended the sample being simple, but sorry
> for the bogus example. But the problem is not there. The problem is,
> the trigger is called for DROP, the function returns no tuples. I'm
> not sure DROP is the only command to cause the behavior, but if no
> tuples means DROP, we should document that behavior. Otherwise, we
> need to document something like:
>
> "pg_event_trigger_ddl_commands() may omit some of the commands and may
> return no tuples."
>
> But it is quite odd.

Well, I'm not sure what you're saying here. It seems like you're
saying the feature is broken. If that's true, instead of documenting
that it doesn't work, shouldn't we fix it?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2020-03-12 13:09:07 Re: Parallel copy
Previous Message Alexey Kondratov 2020-03-12 12:57:49 Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line