| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Maciek Sakrejda <m(dot)sakrejda(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints |
| Date: | 2022-03-22 15:23:16 |
| Message-ID: | CA+TgmoZxiVfmcj1d2R0B2jcn898jLzmQ+2ZO=pGYP+=fbNCxXg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 22, 2022 at 5:00 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> In my previous patch mistakenly I used src_dboid instead of
> dest_dboid. Fixed in this version. For destination db I have used
> lock mode as AccessSharedLock. Logically if we see access wise we
> don't want anyone else to be accessing that db but that is anyway
> protected because it is not visible to anyone else. So I think
> AccessSharedLock should be correct here because we are just taking
> this lock because we are accessing pages in shared buffers from this
> database's relations.
Here's my worked-over version of your previous patch. I haven't tried
to incorporate your incremental patch that you just posted.
--
Robert Haas
EDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Add-new-block-by-block-strategy-for-CREATE-DATABA.patch | application/octet-stream | 59.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2022-03-22 15:24:23 | Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints |
| Previous Message | Julien Rouhaud | 2022-03-22 15:14:44 | Re: New Object Access Type hooks |