Re: es_query_dsa is broken

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: es_query_dsa is broken
Date: 2017-12-18 17:34:27
Message-ID: CA+TgmoZxbTS8hM6bm-1i_mZ_KLgRrNVO7aAG3wtyOzMUQSUEEg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Dec 17, 2017 at 7:35 PM, Thomas Munro
<thomas(dot)munro(at)enterprisedb(dot)com> wrote:
> Andreas Seltenreich found a query[1] that suffers from this bug
> (thanks!), and Amit confirmed that this patch fixes it, but further
> sqlsmith fuzz testing with the patch applied also revealed that it
> failed to handle the case where pei is NULL because parallelism was
> inhibited. Here's a new version to fix that. Someone might prefer a
> coding with "if" rather than the ternary operator, but I didn't have a
> strong preference.

Looks OK to me. Committed and back-patched to v10.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bossart, Nathan 2017-12-18 17:35:52 Re: BUG #14941: Vacuum crashes
Previous Message Robert Haas 2017-12-18 17:14:24 Re: Protect syscache from bloating with negative cache entries