Re: pgsql: Fix problems related to RangeTblEntry members enrname and enrtup

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Fix problems related to RangeTblEntry members enrname and enrtup
Date: 2017-06-15 14:47:54
Message-ID: CA+TgmoZxV7h2i1hr3acut+cro2bSAr5T_-hzZBhSQNgQLaeF_g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, Jun 15, 2017 at 10:17 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Wed, Jun 14, 2017 at 4:30 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> This really should have involved a catversion bump. But we just
>>> had one earlier today, so in practice it might not matter.
>
>> Oh, because of stored rules using the old RangeTblEntry serialization
>> format? Sorry, I totally missed that.
>
> Yeah, exactly. In practice I'm not sure a stored rule/view could contain
> an RTE_NAMEDTUPLESTORE RangeTblEntry, but if it did, there'd be a problem.

I think that's not possible, so we're probably fine, even apart from
the fact that we've bumped catversion multiple times since beta1.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2017-06-15 14:48:25 pgsql: psql: Improve display of "for all tables" publications
Previous Message Tom Lane 2017-06-15 14:17:56 Re: pgsql: Fix problems related to RangeTblEntry members enrname and enrtup