| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: EXPLAIN VERBOSE with parallel Aggregate |
| Date: | 2016-04-23 01:58:00 |
| Message-ID: | CA+TgmoZxLnhvj86OJaFGiekRp6VGHNpnusCgHTNO1U5jBvgK3w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Apr 22, 2016 at 5:36 PM, David Rowley
<david(dot)rowley(at)2ndquadrant(dot)com> wrote:
> I really don't think that we should print FILTER details in a combine
> aggregate node. We'd be claiming to be doing something that we're
> actually not doing. Please see advance_aggregates() in nodeAgg.c, and
> compare that to combine_aggregates(), which is used when combineStates
> == true. Notice that only advance_aggregates() bothers with the
> aggfilter clause.
I think you're wrong. The Output line says what that node outputs,
not how it's computed. And a FinalizeAggregate on top of a
PartialAggregate produces the same output as an Aggregate.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2016-04-23 02:11:02 | Re: EXPLAIN VERBOSE with parallel Aggregate |
| Previous Message | Bruce Momjian | 2016-04-23 00:58:26 | Re: pg_dump / copy bugs with "big lines" ? |