Re: Set log_lock_waits=on by default

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Christoph Berg <myon(at)debian(dot)org>
Cc: Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Michael Banck <mbanck(at)gmx(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Set log_lock_waits=on by default
Date: 2024-07-19 15:12:48
Message-ID: CA+TgmoZw=uagLNBfji=3EW31yR6OL092=OXqi1FM0_doYSCSLw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jul 19, 2024 at 10:22 AM Christoph Berg <myon(at)debian(dot)org> wrote:
> I'd argue this is exactly what I mean by "this system has a problem".
> Telling the user about that makes sense.

That's a fair position.

> > cautious about this than most people on this thread: log_checkpoints
> > won't generate more than a few lines of output per checkpoint
> > interval, and a checkpoint cycle will be on the order of minutes, so
> > it's really never that much volume. On the other hand, in theory, this
> > setting can generate arbitrarily many messages.
>
> Well, it's still limited by 1 message per second (times
> max_connections). It won't suddenly fill up the server with 1000
> messages per second.

You make it sound like running with max_connections=5000 is a bad idea.

(That was a joke, but yes, people actually do this, and no, it doesn't go well.)

> The log volume is the lesser of the problems. Not printing the message
> just because the system does have a problem isn't the right fix.

Yeah.

> Let's fix the default. People who have a problem can still disable it,
> but then everyone else gets the useful messages in the first iteration.

Reasonable.

--
Robert Haas
EDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jelte Fennema-Nio 2024-07-19 15:16:19 Re: Report search_path value back to the client.
Previous Message Tom Lane 2024-07-19 15:06:47 Re: Build with LTO / -flto on macOS