From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp> |
Cc: | Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, PgHacker <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [v9.2] DROP statement reworks |
Date: | 2011-10-19 16:01:39 |
Message-ID: | CA+TgmoZuA=Fb26D36v3eErWRJXLXJTejO=c=jF36R4T0NPaheA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Oct 13, 2011 at 12:46 PM, Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp> wrote:
> And, also I added regression test cases to detect these code paths,
> because some of object types does not cover the case when it was
> dropped.
These regression tests seem busted to me. First, I applied the part 2
patch. The regression tests failed. Then, I applied the part 3
patch. Then they passed. So far so good. Then, I took the
regression test portion of the part 2 and part 3 patches and applied
just those. That also fails.
Can we come up with a set of regression tests that:
- passes on unmodified master
- still passes with the part 2 patch applied
- also passes with both the part 2 and part 3 patches applied
AIUI, this patch isn't supposed to be changing any behavior, just
consolidating the code.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Greg Jaskiewicz | 2011-10-19 16:05:43 | Re: Bug in walsender when calling out to do_pg_stop_backup (and others?) |
Previous Message | Florian Pflug | 2011-10-19 15:54:22 | Re: Bug in walsender when calling out to do_pg_stop_backup (and others?) |