| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com> |
| Cc: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: fdw_scan_tlist for foreign table scans breaks EPQ testing, doesn't it? |
| Date: | 2015-07-22 14:18:39 |
| Message-ID: | CA+TgmoZr2Bvuqn4VUcjxUWgZ-D=HAviYB_Pj1g3G5aGCduOFCg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 22, 2015 at 8:13 AM, Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com> wrote:
>> No, what I'm concerned about is the case when scanrelid > 0.
>>
> Hmm. if scanrelid > 0, then fdw_scan_tlist should be NIL.
> I want to put Assert(scanrelid==0 || fdw_scan_tlist == NIL) just after
> the GetForeignPlan() in createplan.c.
>
> I'm curious why you tried to put valid fdw_scan_tlist for scanrelid > 0.
> It's unusual.
Allowing that was part of the point of Tom Lane's commit
1a8a4e5cde2b7755e11bde2ea7897bd650622d3e. See the second bullet
point, after the comma.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Marti Raudsepp | 2015-07-22 14:20:31 | Re: [PATCH] pg_upgrade fails when postgres/template1 isn't in default tablespace |
| Previous Message | Robert Haas | 2015-07-22 14:15:19 | Re: [PROPOSAL] VACUUM Progress Checker. |