Re: -DDISABLE_ENABLE_ASSERT

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: -DDISABLE_ENABLE_ASSERT
Date: 2014-05-22 20:37:42
Message-ID: CA+TgmoZpTXEEJxo5eoCpPBHM2CJmf4-NcBaPBv=-ZWew07P3bw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 22, 2014 at 4:31 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> Since there seem to be multiple static checkers (coverity, clang
> checker) having problems with assert_enabled can we just optionally
> disable it?
> I am thinking of replacing it by a AssertionsEnabled() macro which then
> is unconditionally defined when DISABLE_ENABLE_ASSERT is defined.

Uh, probably. But I think you need a better name; specifically, one
that doesn't contain two words which are antonyms.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-05-22 20:47:37 Re: -DDISABLE_ENABLE_ASSERT
Previous Message Tom Lane 2014-05-22 20:37:35 Re: -DDISABLE_ENABLE_ASSERT