Re: pgindent

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgindent
Date: 2016-04-27 16:00:43
Message-ID: CA+TgmoZohm828KXH2AUFPQv0zTsv7zb4z7KSZUeP+H6UFNXc9w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Apr 27, 2016 at 11:57 AM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> On Wed, Apr 27, 2016 at 11:51:42AM -0400, Robert Haas wrote:
>> >> It mostly just adds new typedefs that have
>> >> appeared over the last year, but it also realphabetizes the file -
>> >> some things that were added incrementally seem to have ended up in
>> >> what is, at least according to what sort likes to do on my machine,
>> >> the wrong place in the file.
>> >
>> > Is it just me, or is the sort order in that file a bit confusing? The
>> > whole thing about upper and lower case being separated seems to make it
>> > much harder than necessary to manually insert something in the right
>> > place..
>>
>> Except for recently-manually-added entries, it seems to match what
>> sort wants to do on my system exactly. Which seems good.
>
> Well, sort ordering is all related to your collation setting:
>
> $ echo "a
> > A" | LC_COLLATE="" sort
> a
> A
>
> $ echo "a
> A" | LC_COLLATE="en_US" sort
> A
> a

Sure. I guess we could resort that file with LC_COLLATE=C. But my
point was mostly just that the ordering is hardly haphazard.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2016-04-27 16:03:38 Re: Suspicious behaviour on applying XLOG_HEAP2_VISIBLE.
Previous Message Robert Haas 2016-04-27 15:59:39 Re: Suspicious behaviour on applying XLOG_HEAP2_VISIBLE.