Re: Unify drop-by-OID functions

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Unify drop-by-OID functions
Date: 2020-05-01 15:44:11
Message-ID: CA+TgmoZn1t2+wUabUHK0=kxLHvQHL6QVnBCBSA+3mZcmgC10Hg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, May 1, 2020 at 10:51 AM Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
> +1

+1 from me, too, but I have a few suggestions:

+DropGenericById(const ObjectAddress *object)

How about "Generic" -> "Object" or "Generic" -> "ObjectAddress"?

+ elog(ERROR, "cache lookup failed for %s entry %u",
+ elog(ERROR, "could not find tuple for class %u entry %u",

How about "entry" -> "with OID"?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message James Coleman 2020-05-01 16:32:41 Re: pg_rewind docs correction
Previous Message Dilip Kumar 2020-05-01 15:10:51 Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions