Re: Event Triggers reduced, v1

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Event Triggers reduced, v1
Date: 2012-07-02 17:56:36
Message-ID: CA+TgmoZm5fuhnCRaOKvkAaDJ3J-0F3iYX-RHx98nUv4z9dRCUw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jun 29, 2012 at 5:38 PM, Dimitri Fontaine
<dimitri(at)2ndquadrant(dot)fr> wrote:
> Will do a whole warning check pass later. Can you give me your local
> Makefile trick to turn them into hard errors again please? :)

echo COPT=-Werror > src/Makefile.custom

Your latest patch contains a warning about using a variable
uninitialized that seems to indicate that you didn't test this very
carefully: in get_event_triggers, current_any_name is set but not
used.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2012-07-02 17:57:03 Re: Event Triggers reduced, v1
Previous Message Andres Freund 2012-07-02 17:53:25 Re: [COMMITTERS] pgsql: Make walsender more responsive.