Re: [PATCH] Unremovable tuple monitoring

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Royce Ausburn <royce(dot)ml(at)inomial(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Yeb Havinga <yebhavinga(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Kevin Grittner <kevin(dot)grittner(at)wicourts(dot)gov>
Subject: Re: [PATCH] Unremovable tuple monitoring
Date: 2011-11-16 13:11:16
Message-ID: CA+TgmoZktbfNLM9OU=-oecRvHdL_mmCmPEWKd9GMDVfh7AYZxA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Nov 15, 2011 at 10:02 PM, Royce Ausburn <royce(dot)ml(at)inomial(dot)com> wrote:
> Fair enough -- someone knowledgable could set that up if they wanted.  My goal was mostly to have something helpful in the logs.  If that's not something postgres wants/needs Ill drop it =)

IMHO, it's generally not desirable to provided hard-coded
functionality that could easily be duplicated in user-space. We can't
really know whether the user wants this warning at all, and if so what
the cut-off ought to be for a "too old" transaction, and how often the
warning should be emitted. It's far more flexible for the user to set
it up themselves. Log clutter is a major problem for some users, and
we shouldn't add to it without a fairly compelling reason.

Just to take an example of something that *couldn't* easily be done in
userspace, suppose VACUUM emitted a NOTICE when the number of
recently-dead tuples was more than a certain (configurable?)
percentage of the table. That's something that VACUUM could calculate
(or at least estimate) while scanning the table, but it wouldn't be so
easy for the user to get that same data, at least not cheaply. Now
I'm not sure we need that particular thing; it's just an example.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2011-11-16 13:50:01 Re: Adding Node support in outfuncs.c and readfuncs.c
Previous Message Robert Haas 2011-11-16 13:03:42 Re: [PATCH] Unremovable tuple monitoring