| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Subject: | Re: More race conditions in logical replication |
| Date: | 2017-07-25 18:29:50 |
| Message-ID: | CA+TgmoZkr9inVkRJhH8dxt7BsY78dMAGOiu8v6kdoJJ8k8E_kA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 25, 2017 at 1:42 PM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> As I see it, we need to backpatch at least parts of this patch. I've
> received reports that in earlier branches pglogical and BDR can
> sometimes leave slots behind when removing nodes, and I have a hunch
> that it can be explained by the bugs being fixed here. Now we cannot
> use condition variables in back-branches, so we'll need to figure out
> how to actually do it ...
If all you had to back-patch was the condition variable code itself,
that might not really be all that bad, but it depends on the
WaitEventSet stuff, which I think is far too dangerous to back-patch.
However, you might be able to create a dumber, slower version that
only uses WaitLatch.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-07-25 18:32:30 | Re: More race conditions in logical replication |
| Previous Message | Robert Haas | 2017-07-25 18:24:20 | Re: Create language syntax is not proper in pg_dumpall and not working using pg_upgrade |