Re: Review of pg_archivecleanup -x option patch

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Jaime Casanova <jaime(at)2ndquadrant(dot)com>
Cc: Greg Smith <greg(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Review of pg_archivecleanup -x option patch
Date: 2012-04-05 18:20:00
Message-ID: CA+TgmoZkAx4z4aJUKGxL3YM0QxSuO8pUmiaoYRt9zwMEoNU4Hg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 28, 2012 at 12:13 PM, Jaime Casanova <jaime(at)2ndquadrant(dot)com> wrote:
> On Wed, Mar 28, 2012 at 8:47 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>>>
>>>> $ ./pg_archivecleanup -x "bz2" /tmp 000000010000000100000058
>>>
>>> Hmm, but I thought that the idea was that the extension was optional.
>>> Perhaps I'm missing something but I don't think the previous patch
>>> will complain about that either; or at least I don't see why the
>>> behavior should be any different.
>>
>> Can someone enlighten me on this point?
>>
>
> mmm! you're right... it's not complaining either... i was sure it was...
> and i'm not sure i want to contor things for that...
>
> so, just forget my last mail about that... your refactor is just fine for me

OK, committed that way.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2012-04-05 18:23:03 Re: Last gasp
Previous Message Simon Riggs 2012-04-05 18:17:14 Re: Last gasp