| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Steve Singer <steve(at)ssinger(dot)info> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Jan Wieck <jan(at)wi3ck(dot)info>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Moving of INT64_FORMAT to c.h |
| Date: | 2014-10-22 20:17:28 |
| Message-ID: | CA+TgmoZisf0cVNxUfBegqnUxAS2ZwpTiR2HcMksr0m0kxOvyVw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 22, 2014 at 4:12 PM, Steve Singer <steve(at)ssinger(dot)info> wrote:
> So the header of c.h says "Note that the definitions here are not intended
> to be exposed to clients"
> but
> postgres_fe.h says "This should be the first file included by PostgreSQL
> client libraries and"
>
> Should client programs that live outside the postgres source tree be
> including postgres_fe.h ? I have a feeling the answer is no. If the answer
> is no, then why does a make install install postgres_fe.h ?
I think the answer is yes.
> Slonik used to include postgre_fe.h but back in 2011 or so we stopped doing
> so because it was causing issues (I think on win32 builds)
That seems like something we ought to consider fixing, but obviously
we'd need more details.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2014-10-22 20:31:30 | Re: Moving of INT64_FORMAT to c.h |
| Previous Message | Steve Singer | 2014-10-22 20:12:06 | Re: Moving of INT64_FORMAT to c.h |