| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: standby promotion can create unreadable WAL |
| Date: | 2022-08-26 14:23:41 |
| Message-ID: | CA+TgmoZhvRG_7FjVw60a6soU5uJWo93bsONPieuJtPrn1hs_vg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Aug 26, 2022 at 10:06 AM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> There's a small typo in the comment: "When find that". I suppose that
> was meant to be "When we find that". You end that para with "and thus
> we should not do this", but that sounds like it wouldn't matter if we
> did. Maybe "and thus doing this would be wrong, so skip it." or
> something like that. (Perhaps be even more specific and say "if we did
> this, we would later create an overwrite record in the wrong place,
> breaking everything")
I think that saying that someone should not do something implies
pretty clearly that it would be bad if they did. But I have no problem
with your more specific language, and as a general rule, it's good to
be specific, so let's use that.
v2 attached.
Thanks for chiming in.
--
Robert Haas
EDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| fix-contrecord-condition-v2.patch | application/octet-stream | 2.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-08-26 14:27:00 | Re: windows cfbot failing: my_perl |
| Previous Message | Andres Freund | 2022-08-26 14:14:32 | Re: Strip -mmacosx-version-min options from plperl build |