Re: BTMaxItemSize seems to be subtly incorrect

On Wed, Jun 8, 2022 at 7:44 PM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> FWIW I don't see much difference between borrowing special space and
> adding something to BTPageOpaqueData. If anything I'd prefer the
> latter.

I think this discussion will take us too far afield from the topic of
this thread, so I'll just say here that wouldn't solve the problem I
was trying to tackle.

> Here's why: BTMaxItemSizeNoHeapTid() is actually what BTMaxItemSize()
> looked like prior to Postgres 12. So the limit on internal pages never
> changed, even in Postgres 12. There was no separate leaf page limit
> prior to 12. Only the rules on the leaf level ever really changed.

Yeah, I noticed that, too.

Are you going to code up a patch?

--
Robert Haas
EDB: http://www.enterprisedb.com