Re: pgsql: Avoid using ambiguous word "positive" in error message.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Fujii Masao <fujii(at)postgresql(dot)org>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Avoid using ambiguous word "positive" in error message.
Date: 2021-08-30 14:03:39
Message-ID: CA+TgmoZefaY3m1wgU3v-tGbSa3Qibj2jCt6T1k5Y6ybaRqqZ+Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Tue, Aug 24, 2021 at 10:49 PM Fujii Masao <fujii(at)postgresql(dot)org> wrote:
> Avoid using ambiguous word "positive" in error message.

The new style seems good, but I don't really agree that "positive" and
"non-negative" are ambiguous. "positive" means >0 and "non-negative"
means >= 0, because 0 is neither positive nor negative.

This is just nitpicking, though. I think the change is an improvement.

--
Robert Haas
EDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2021-08-30 14:16:16 Re: pgsql: Avoid using ambiguous word "positive" in error message.
Previous Message Fujii Masao 2021-08-30 12:41:43 pgsql: pgbench: Avoid unnecessary measurement of connection delays.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-08-30 14:11:22 Re: Can we get rid of repeated queries from pg_dump?
Previous Message Dagfinn Ilmari Mannsåker 2021-08-30 13:38:19 Re: [PATCH] Tab completion for ALTER TABLE … ADD …