| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Bug in TupleQueueReaderNext() ? |
| Date: | 2015-12-18 17:41:25 |
| Message-ID: | CA+TgmoZefSPfcTQ4KkEEkFfevsrbOs2ksms_PqShWkcMiwYuUg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 16, 2015 at 1:09 AM, Rushabh Lathia
<rushabh(dot)lathia(at)gmail(dot)com> wrote:
> TupleQueueReaderNext() always pass true for the nowait into
> shm_mq_receive() call. I think here it need to pass the nowait
> which is passed by the caller of TupleQueueReaderNext.
>
> This is usefull if the caller want TupleQueueReaderNext() to wait
> until it gets the tuple from the particular queue.
Boy, that's an embarassing mistake. *blushes*
Thanks for the report and fix. Committed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-12-18 17:42:29 | Schedule plans for upcoming Postgres releases |
| Previous Message | Robert Haas | 2015-12-18 17:35:25 | Re: Re: Reusing abbreviated keys during second pass of ordered [set] aggregates |