From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: fix CRC algorithm in WAL reliability docs |
Date: | 2024-08-08 19:13:50 |
Message-ID: | CA+TgmoZeHHYTY0_usgX3vf6G=xOdH0BLucZB2G17HL+57NCZsA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Aug 8, 2024 at 1:51 PM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
> I noticed that the "WAL reliability" documentation says that we use CRC-32
> for WAL records and two-phase state files, but we've actually used CRC-32C
> since v9.5 (commit 5028f22). I've attached a short patch to fix this that
> I think should be back-patched to all supported versions.
>
> I've attached a second patch that standardizes how we refer to these kinds
> of algorithms in our docs. Specifically, it adds dashes (e.g., "CRC-32C"
> instead of "CRC32C"). Wikipedia uses this style pretty consistently [0]
> [1] [2], and so I think we should, too. I don't think this one needs to be
> back-patched.
>
> Thoughts?
LGTM.
--
Robert Haas
EDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2024-08-08 19:18:36 | Re: Don't overwrite scan key in systable_beginscan() |
Previous Message | Robert Haas | 2024-08-08 18:59:54 | Re: Add LSN <-> time conversion functionality |