Re: pgsql: Make walsender more responsive.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Make walsender more responsive.
Date: 2012-07-02 15:19:39
Message-ID: CA+TgmoZdPKrSWHfmLdkhzybMnc8nisfBrmac96d5uu8qUiT=0Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Mon, Jul 2, 2012 at 11:06 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Mon, Jul 2, 2012 at 10:34 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> (I got a good laugh out of the idea of "contented locks".)
>
>> Uh... what? I thought the meaning of that was perfectly clear.
>
> My dictionary defines "contented" as "happy and at ease". I think
> the word intended here is "contended":

Oh, nuts. My eyes skimmed right over that one after you pointed it out.

> + /* wakeup the WalSnd now that we outside contented locks */
>
> not to mention that this sentence no verb. I don't hold such things
> against patch submitters whose first language isn't English, but
> committers whose first language *is* English ought to fix them.

OK.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2012-07-02 15:29:25 pgsql: Work a little harder on comments for walsender wakeup patch.
Previous Message Tom Lane 2012-07-02 15:06:16 Re: pgsql: Make walsender more responsive.

Browse pgsql-hackers by date

  From Date Subject
Next Message Ants Aasma 2012-07-02 15:22:15 Re: [PATCH] Lazy hashaggregate when no aggregation is needed
Previous Message Tom Lane 2012-07-02 15:17:19 Re: small bug on 3-digit years in 9.2-dev