| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Kevin Grittner <kgrittn(at)ymail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Joachim Wieland <joe(at)mcknight(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Materialized view assertion failure in HEAD |
| Date: | 2013-03-20 18:24:50 |
| Message-ID: | CA+TgmoZaDAOkNjDOah9-2Z9Zho2G94qggcY6U_hxRp5ATLFGYg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 18, 2013 at 4:42 PM, Kevin Grittner <kgrittn(at)ymail(dot)com> wrote:
> I want to give everyone else a chance to weigh in before I start
> the pendulum swinging back in the other direction on OIDs in MVs.
> Opinions?
I agree that it's probably better to just disallow this, but I have to
admit I don't like your proposed patch much. It seems to me that the
right place to fix this is in interpretOidsOption(), by returning
false rather than default_with_oids whenever the relation is a
materialized view. That would require passing the relkind as an
additional argument to interpretOidsOption(), but that doesn't seem
problematic.
Then, the parser could just error out if OIDS=anything appears in the
options list, but it wouldn't need to actually kludge the options list
as you've done here.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2013-03-20 18:29:06 | Re: Let's invent a function to report lock-wait-blocking PIDs |
| Previous Message | Bruce Momjian | 2013-03-20 18:17:55 | Re: pg_upgrade segfaults when given an invalid PGSERVICE value |