From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | merging duplicate definitions of adjust_relid_set |
Date: | 2017-03-17 17:33:42 |
Message-ID: | CA+TgmoZ_1bUAADs5oHhU07_t=3zdf_foKGDAFGWYvmcCbwn63Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
While reviewing Ashutosh Bapat's partitionwise join code, I noticed
he'd run up against the problem that adjust_relid_set() is defined as
static in two different source files, and he wanted to call it from a
third file. I didn't much like his solution to that problem, which
was to rename one of them and make that definition non-static; I think
it would be better to keep the existing name and stop defining it in
multiple places. However, I discovered that there wasn't really an
obviously-good place to put the function; neither prepunion.c nor
rewriteManip.c, the two files that contain static versions as of now,
seem like an appropriate place from which to expose it, and I didn't
find anything else that I was wildly in love with, either. The
attached patch puts it in var.c, because it didn't look horrible and I
thought it wasn't worth creating a new file just for this.
Objections, better ideas?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment | Content-Type | Size |
---|---|---|
merge-adjust-relid-sets.patch | application/octet-stream | 4.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2017-03-17 17:39:26 | Re: [COMMITTERS] pgsql: Remove objname/objargs split for referring to objects |
Previous Message | Tom Lane | 2017-03-17 17:27:49 | Re: \if, \elseif, \else, \endif (was Re: PSQL commands: \quit_if, \quit_unless) |