| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix comment in ATExecValidateConstraint |
| Date: | 2016-07-29 14:50:40 |
| Message-ID: | CA+TgmoZXugh77M1tSVYZgSOE9U3TtzvKaCQYGwWYct-K0f0oJQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jul 25, 2016 at 4:18 AM, Amit Langote
<Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> The comment seems to have been copied from ATExecAddColumn, which says:
>
> /*
> * If we are told not to recurse, there had better not be any
> - * child tables; else the addition would put them out of step.
>
> For ATExecValidateConstraint, it should say something like:
>
> + * child tables; else validating the constraint would put them
> + * out of step.
>
> Attached patch fixes it.
I agree that the current comment is wrong, but what does "out of step"
actually mean here, anyway? I think this isn't very clear.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2016-07-29 15:13:30 | Re: sslmode=require fallback |
| Previous Message | Stephen Frost | 2016-07-29 14:44:29 | Re: Why we lost Uber as a user |