| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Tatsuo Ishii <ishii(at)postgresql(dot)org>, Hari Babu <haribabu(dot)kommi(at)huawei(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: ALTER SYSTEM SET command to change postgresql.conf parameters |
| Date: | 2014-01-06 19:22:10 |
| Message-ID: | CA+TgmoZXAKLz-HBZA-F7z4uWZt8HQwE933jBmzqHWGngrZ0F6Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 6, 2014 at 9:48 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>> Couldn't we also handle this by postponing FreeConfigVariables until
>> after the if (error) block?
>
> Wouldn't doing that way can lead to bigger memory leak, if error level
> is ERROR. Though in current fix also it can leak memory but it will be
> just for ErrorConfFile_save. I think some similar case can happen for
> 'pre_value' in code currently as well, that's why I have fixed it in a
> similar way in patch.
I was assuming that error-recovery would reset the containing memory
context, but I'm not sure what memory context we're executing in at
this point.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | AK | 2014-01-06 19:41:16 | How to reproduce serialization failure for a read only transaction. |
| Previous Message | Robert Haas | 2014-01-06 19:16:25 | Re: [PATCH] Store Extension Options |