| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru> |
| Subject: | Re: [PATCH] Remove unused argument in btree_xlog_split |
| Date: | 2017-04-07 18:21:02 |
| Message-ID: | CA+TgmoZWYdhB1rQarOrJaiT1eKUDDW0iG3PmFZZMTNcX316D3A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 6, 2017 at 8:21 AM, Aleksander Alekseev
<a(dot)alekseev(at)postgrespro(dot)ru> wrote:
> Hi Robert,
>
>> Hmm. I don't see anything wrong with that, particularly, but it seems
>> we also don't need the distinction between XLOG_BTREE_SPLIT_L and
>> XLOG_BTREE_SPLIT_L_ROOT or likewise between XLOG_BTREE_SPLIT_R and
>> XLOG_BTREE_SPLIT_R_ROOT -- in which case I think this patch should go
>> a little further and do all of that together.
>
> Thank you for sharing your thoughts on this patch. Here is a new
> version.
Thanks. Please add this to the next CommitFest, as there seems to be
no urgency (and some risk) in committing it right before feature
freeze.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Keith Fiske | 2017-04-07 18:31:23 | Re: Partitioned tables vs GRANT |
| Previous Message | Joe Conway | 2017-04-07 18:05:20 | Partitioned tables vs GRANT |