Re: Is custom MemoryContext prohibited?

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Geoghegan <pg(at)bowt(dot)ie>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Kohei KaiGai <kaigai(at)heterodb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Is custom MemoryContext prohibited?
Date: 2020-02-05 15:41:28
Message-ID: CA+TgmoZUAgkD9oqOedt=Ykvi_DW6J+drtU9Bjtn4omSnO_hN2g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Feb 5, 2020 at 10:09 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> an enum field right in the context. You'll have to do an extra step to
> discover the context's type, and if you jump to the wrong conclusion
> and do, say,
> p *(AllocSetContext *) ptr_value
> when it's really some other context type, there won't be anything
> as obvious as "type = T_GenerationContext" in what is printed to
> tell you you were wrong.

Doesn't the proposed magic number address this concern?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Konstantin Knizhnik 2020-02-05 15:48:38 Re: [Proposal] Global temporary tables
Previous Message Robert Haas 2020-02-05 15:40:59 Re: Is custom MemoryContext prohibited?