| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | David Steele <david(at)pgmasters(dot)net> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
| Subject: | Re: pg_combinebackup fails on file named INCREMENTAL.* |
| Date: | 2024-04-16 13:25:47 |
| Message-ID: | CA+TgmoZU3DiJUupVKeZ2Zb-YgSGNhDSQ7esuHOaLjm-hSn1-Xw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Apr 15, 2024 at 10:12 PM David Steele <david(at)pgmasters(dot)net> wrote:
> Anyway, I think it should be fixed or documented as a caveat since it
> causes a hard failure on restore.
Alright, I'll look into this.
> I know Tomas added some optimizations that work best with --no-manifest
> but if we can eventually read compressed tars (which I expect to be the
> general case) then those optimizations are not very useful.
My belief is that those optimizations work fine with or without
manifests; you only start to lose the benefit in cases where you use
different checksum types for different backups that you then try to
combine. Which should hopefully be a rare case.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nazir Bilal Yavuz | 2024-04-16 13:37:50 | Re: Typos in the code and README |
| Previous Message | Robert Haas | 2024-04-16 13:22:34 | Re: pg_combinebackup fails on file named INCREMENTAL.* |