| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Sami Imseih <samimseih(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jeff Davis <pgsql(at)j-davis(dot)com>, Thom Brown <thom(at)linux(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: making EXPLAIN extensible |
| Date: | 2025-03-19 14:38:13 |
| Message-ID: | CA+TgmoZU1_arvV_gq1MfgQnW1LvK4m67Cp_O3jGMYM971gm45A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 18, 2025 at 11:21 PM Sami Imseih <samimseih(at)gmail(dot)com> wrote:
> > > Do you want to propose a patch?
> >
> > yes, will attach a patch shortly.
>
> Attached is a patch to add a hook to allow extensions
> to add additional option validations. The hook takes
> in the ExplainState as an argument and returns void.
> It is expected the extension will raise an error if the
> validation fails.
Since the new hook will be called from explain_state.c, please declare
it in explain_state.h.
I think the header-file comment should be just one line rather than a
block comment as we do for other hooks in this area. If you think a
more detailed explanation is needed, I'd put that in the .c file.
Is there any value in passing "options" or "pstate" to the hook?
Couldn't the hook want to use "pstate" for error reporting purposes?
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2025-03-19 14:47:50 | Re: AIO v2.5 |
| Previous Message | Christophe Pettus | 2025-03-19 14:13:03 | Re: Vacuuming the free space map considered harmful? |