| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Rafia Sabih <rafia(dot)sabih(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Parallel Append implementation |
| Date: | 2017-10-28 09:50:46 |
| Message-ID: | CA+TgmoZTLKtQ9UCGo4zU1kzrCBxUE_iEwxeNNbDT5OCjRVXRxg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 19, 2017 at 9:05 AM, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> wrote:
>> + * ExecAppendEstimate
>> + *
>> + * estimates the space required to serialize Append node.
>>
>> Ugh, this is wrong, but I notice it follows various other
>> equally-wrong comments for other parallel-aware node types. I guess
>> I'll go fix that. We are not in serializing the Append node.
>
> I didn't clealy get this. Do you think it should be "space required to
> copy the Append node into the shared memory" ?
No, because the Append node is *NOT* getting copied into shared
memory. I have pushed a comment update to the existing functions; you
can use the same comment for this patch.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-10-28 10:05:26 | Re: Fix typo in blvacuum.c |
| Previous Message | Robert Haas | 2017-10-28 09:37:36 | Re: Partition-wise aggregation/grouping |