| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Acceptable/Best formatting of callbacks (for pluggable storage) |
| Date: | 2019-01-11 15:32:03 |
| Message-ID: | CA+TgmoZSGMUe62ACpmrJk7UmePYnR4G2daR1NVs18PyLEKP3Aw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 10, 2019 at 11:45 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> void (*relation_set_new_filenode) (Relation relation,
> char persistence,
> TransactionId *freezeXid,
> MultiXactId *minmulti);
Honestly, I don't see the problem with that, really. But you could
also use the style that is used in fdwapi.h, where we have a typedef
for each callback first, and then the actual structure just declares a
function pointer of each time. That saves a bit of horizontal space
and might look a little nicer.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2019-01-11 15:33:48 | Re: Acceptable/Best formatting of callbacks (for pluggable storage) |
| Previous Message | Pavel Stehule | 2019-01-11 15:22:11 | Re: [HACKERS] generated columns |