| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Jeff Davis <pgsql(at)j-davis(dot)com>, Thom Brown <thom(at)linux(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: making EXPLAIN extensible |
| Date: | 2025-03-05 21:13:06 |
| Message-ID: | CA+TgmoZR-j1nqc9uz-9SMb2BecM-_bz4btixJ2X=9JCaCuEWEQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 5, 2025 at 4:00 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Ah. I was mistakenly assuming that 0001 would compile on its own ;-)
Oopsie.
> Got it. So does that mean we can remove any #include's from explain.h
> after moving the struct definition?
Good question. It looks like "lib/stringinfo.h" can come out but the
other two are still needed, so there is not much gain. But I've made
that change in the attached v4.
I also added "= NULL" to a couple of variable initialization in 0003
in this version, because Andres pointed out to me that cfbot was
seeing compiler warnings. It's a little odd that it warned, because
the variables were initialized by a switch over all enum values, but I
guess some compiler doesn't find that convincing enough.
--
Robert Haas
EDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0002-Add-some-new-hooks-so-extensions-can-add-details-.patch | application/octet-stream | 4.3 KB |
| v4-0003-pg_overexplain-Additional-EXPLAIN-options-for-deb.patch | application/octet-stream | 59.0 KB |
| v4-0001-Make-it-possible-for-loadable-modules-to-add-EXPL.patch | application/octet-stream | 29.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2025-03-05 21:17:25 | Re: Make tuple deformation faster |
| Previous Message | James Hunter | 2025-03-05 21:11:42 | Re: Make tuple deformation faster |