From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Fabrízio Mello <fabriziomello(at)gmail(dot)com>, Thom Brown <thom(at)linux(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Parallel Seq Scan |
Date: | 2015-05-21 12:38:33 |
Message-ID: | CA+TgmoZQX4F3v++QASpf+tkZw6f12QY0-RestR=BV7_tossyGQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, May 19, 2015 at 8:45 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Mon, May 11, 2015 at 3:00 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> I think it might be better to try to solve this problem in a more
>> localized way. Can we arrange for planstate->instrumentation to point
>> directory into the DSM, instead of copying the data over later?
>
> Yes, we can do that but I am not sure we can do that for pgBufferUsage
> which is a separate information we need to pass back to master backend.
> One way could be to change pgBufferUsage to a pointer and then allocate
> the memory for same at backend startup time and for parallel workers, it
> should point to DSM. Do you see any simple way to handle it?
No, that seems problematic.
> Another way could be that master backend waits for parallel workers to
> finish before collecting the instrumentation information and buffer usage
> stats. It seems to me that we need this information (stats) after execution
> in master backend is over, so I think we can safely assume that it is okay
> to finish the execution of parallel workers if they are not already finished
> the execution.
I'm not sure exactly where you plan to insert the wait.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2015-05-21 12:42:17 | Re: Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE. |
Previous Message | Heikki Linnakangas | 2015-05-21 12:35:13 | Archiving last incomplete segment as .partial issues |